Replace NBI with NBPackage #660
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request migrates the jMonkeyEngine SDK from the deprecated NetBeans Installer (NBI) infrastructure to NBPackage, as outlined in issue #611. The PR removes the entire legacy NBI stub directory infrastructure, which includes installer templates, build scripts, configuration files, and custom installer UI components. The migration aims to modernize the build process by leveraging NBPackage and Bash scripts for creating cross-platform installers (ZIP, DEB, Windows EXE, and macOS PKG files).
Key changes:
- Complete removal of the NBI stub infrastructure (
nbi/stubdirectory) - Elimination of custom installer panels and wizard components
- Removal of platform-specific NBI build configurations
Reviewed changes
Copilot reviewed 81 out of 111 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| nbi/stub/tmpl.properties | Removed legacy NBI template configuration |
| nbi/stub/template.xml | Removed Ant build template for NBI installers |
| nbi/stub/ext/infra/build/** | Removed NBI build infrastructure for products (JDK, helloworld) |
| nbi/stub/ext/engine/** | Removed custom NBI engine source code, including wizard panels and UI components |
| nbi/stub/ext/components/** | Removed product-specific NBI configuration logic |
Note: This review focuses on the deleted NBI files. The PR description mentions new NBPackage implementation and Bash scripts, but these are not visible in the provided diff, suggesting they may be in different files or commits not shown here.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
https://github.com/jMonkeyEngine/sdk/releases/tag/v3.8.0-stable-sdk2, here. A test release. I tested the x64 Linux and it seemed to work just fine. Need to test the Windows one still. If it works, I'll merge this tomorrow if no objections. So we can move on. I don't think we have much choice on the matter anyway. I added the Linux aarch64, dunno how widespread it is but since we lost the MacOS.. at least we gained something then. I made the build system so that all modifications unfortunately require editing the BASH scripts. There are no parameters available for the Github hook for example. As well as tried to retain the ability to build locally (on *nix), it is easier. The alternative would have been (as per the nbpackage author's example) setting up proper VMs for all targets. Build Windows installer in Windows etc. |
|
Windows installer seems to work as well... |
1 participant
Quite the cleanup. NBI is no more.
Uses NBPackage and heavily leverages Bash scripts. I'm not an expert on either one so there might be some issues there.
Tagging as per usual. Builds ZIP, DEB (as opposed to sh -installer), Windows EXE and MacOS PKG files. MacOS PKGs differ only by bundling the correct JDK. JDKs are automatically downloaded as previously.
After this I suppose it gets a bit easier as we don't need to copy any changed NBI files. This should work regardless of NB version. A bit complicated to understand, hopefully doesn't require so much maintenance...
Current TODO:
Closes #611